[airq] Add support for mold and virus index#19446
Merged
fwolter merged 13 commits intoopenhab:mainfrom Oct 12, 2025
Merged
Conversation
…b#19444) Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
fwolter
reviewed
Oct 7, 2025
fwolter
requested changes
Oct 8, 2025
| channel-type.airq.humidity_abs.label = Absolute Humidity | ||
| channel-type.airq.humidity_abs_maxerr.label = Max. Error Abs. Humidity | ||
| channel-type.airq.humidity_maxerr.label = Max. Error Humidity | ||
| channel-type.airq.mold.label = Mold Index |
Contributor
Author
There was a problem hiding this comment.
Good point, translation is updated.
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
lsiepel
requested changes
Oct 11, 2025
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/i18n/airq_de.properties
Show resolved
Hide resolved
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.airq/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Comment on lines
+76
to
+77
| <channel id="virus_free_maxerr" typeId="virus_free_maxerr"/> | ||
| <channel id="mold_free_maxerr" typeId="mold_free_maxerr"/> |
Contributor
There was a problem hiding this comment.
These two are not added to the readme, not needed?
Contributor
Author
There was a problem hiding this comment.
Until now, the MaxErr channels were not explicitly listed.
@fwolter, should I add them?
Member
There was a problem hiding this comment.
Why not, PR welcome :) Right of the bat, I couldn't find any documentation what exactly the max error value means. I assume it is the tolerance to be expected under the current environmental conditions.
lsiepel
added
the
enhancement
lsiepel
changed the title
- translation are created and maintained in crowdin Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
…ab#19444) Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
lsiepel
requested changes
Oct 11, 2025
Signed-off-by: Philipp Schneider <philipp.schneider@nixo-soft.de>
fwolter
approved these changes
Oct 12, 2025
Member
fwolter
left a comment
fwolter
left a comment
There was a problem hiding this comment.
Thank you all for your contribution and your review effort, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following improvements are available:
The implementation Closes #19444